From f90d5b5d53abb914ee07d695eb3686a3c3f51475 Mon Sep 17 00:00:00 2001 From: Yashas Date: Tue, 18 Aug 2026 12:06:11 +0530 Subject: [PATCH] fix: one recommendation, one card, and a rate quoted to the basis point MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Advisor's recommendation was rendering twice — EvidencePanel had carried a 'Suggested structure' section since before AdvisorPanel existed. Two cards holding one recommendation read as two separate recommendations. AdvisorPanel keeps it, because it also reports whether the manager departed from the advice; the older section is gone. Rate was displayed through pct() at one decimal, so a 15.25% loan showed as 15.3% — a different rate, sitting inches from the correct figure. Two decimals. --- src/components/AdvisorPanel.tsx | 2 +- src/components/EvidencePanel.tsx | 31 ++++++------------------------- 2 files changed, 7 insertions(+), 26 deletions(-) diff --git a/src/components/AdvisorPanel.tsx b/src/components/AdvisorPanel.tsx index 5f3a134..30d536d 100644 --- a/src/components/AdvisorPanel.tsx +++ b/src/components/AdvisorPanel.tsx @@ -81,7 +81,7 @@ export function AdvisorPanel({ row }: { row: Row }) {
- 14.5 ? 'deviation-priced' : 'standard grid'} /> + 14.5 ? 'deviation-priced' : 'standard grid'} />
diff --git a/src/components/EvidencePanel.tsx b/src/components/EvidencePanel.tsx index 05542cd..8e83294 100644 --- a/src/components/EvidencePanel.tsx +++ b/src/components/EvidencePanel.tsx @@ -2,7 +2,7 @@ import { AlertTriangle, Check, Cpu, Scale, X } from 'lucide-react'; import { Badge, Card, Facts } from './core'; import type { Row } from '../api/types'; import { POLICY } from '../api/config'; -import { money, moneyShort, num, pct, ratio, ratioPct, reasonCodes, str } from '../format'; +import { moneyShort, num, pct, ratio, ratioPct, reasonCodes, str } from '../format'; /** * The evidence panel — why the machine decided what it decided. @@ -323,30 +323,11 @@ export function EvidencePanel({ row }: { row: Row }) { )} - {/* The advisory offer, if the advisor has run. Also violet — it is a - suggestion, and it lives in different columns from the committed - offer precisely so it can never be mistaken for one. */} - {num(row.ai_suggested_amount) !== null && ( -
-
- -

Suggested structure

- non-binding — the RM decides -
-
- -
-
- )} + {/* NB: the advisory structure used to be rendered here too. It now lives + ONLY in AdvisorPanel (right-hand column), which shows the same figures + plus whether the manager who issued the offer took the advice or + departed from it. Two cards carrying one recommendation made the + screen look like two separate recommendations. */}
); }