diff --git a/src/screens/Pipeline.jsx b/src/screens/Pipeline.jsx index faa063d..d9fd03b 100644 --- a/src/screens/Pipeline.jsx +++ b/src/screens/Pipeline.jsx @@ -71,11 +71,18 @@ export default function Pipeline() { const { stageUid } = useParams() const navigate = useNavigate() const { client } = useZino() - // "all" is not a stage — it is every open lead in one list. An operator - // wanting to find a lead should not have to guess which queue it is in. + // "all" is not a stage — it is every lead in one list, so an operator + // wanting to find one does not have to guess which queue it is in. + // + // IT MEANS ALL. This view used to drop closed leads, so a lead that was lost + // or onboarded disappeared from the page called "All leads" — the one place + // somebody goes when they cannot find something. A lead that ended is still + // a lead, and "where did it go?" is exactly the question this page exists to + // answer. Closed rows are shown, and dimmed, and can be hidden by choice. const isAll = stageUid === 'all' + const [hideClosed, setHideClosed] = useState(false) const stage = isAll - ? { uid: 'all', name: 'All open leads', kind: 'all', by: 'everyone' } + ? { uid: 'all', name: 'All leads', kind: 'all', by: 'everyone' } : STAGES.find((s) => s.uid === stageUid) const [state, setState] = useState({ status: 'loading', rows: [], total: 0, error: null }) @@ -99,10 +106,9 @@ export default function Pipeline() { .then((res) => { if (cancelled) return let rows = res?.data ?? res?.rows ?? res?.records ?? [] - if (isAll) { - const closed = new Set(STAGES.filter((x) => x.kind === 'end').map((x) => x.name)) - rows = rows.filter((r) => !closed.has(r.current_state_name)) - } + // Nothing is dropped here any more. Whether closed leads are shown + // is a choice made below, on data already fetched — a filter that + // throws rows away at the query cannot be undone by a toggle. // total_count is the size of the QUEUE; rows is one page of at most // 100 of it. Counting the page would quietly under-report a busy stage. const total = isAll ? rows.length : (res?.pagination?.total_count ?? rows.length) @@ -124,6 +130,14 @@ export default function Pipeline() { return () => { cancelled = true; clearInterval(id) } }, [client, stageUid, stage?.name, isAll]) + // Split rather than filtered at the query, so the header can say how many + // are closed instead of silently showing fewer than the page claims. + const CLOSED = new Set(STAGES.filter((x) => x.kind === 'end').map((x) => x.name)) + const closedCount = isAll ? state.rows.filter((r) => CLOSED.has(r.current_state_name)).length : 0 + const shownRows = isAll && hideClosed + ? state.rows.filter((r) => !CLOSED.has(r.current_state_name)) + : state.rows + if (!stage) return
Unknown stage.
return ( @@ -145,9 +159,20 @@ export default function Pipeline() { {state.status === 'ready' ? ( -No records in this stage.
+ {state.status === 'ready' && shownRows.length === 0 ? ( +{isAll ? 'No leads yet.' : 'No records in this stage.'}
) : null} - {state.status === 'ready' && state.rows.length > 0 ? ( + {state.status === 'ready' && shownRows.length > 0 ? (